-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add http method matching #59
Open
Hebilicious
wants to merge
18
commits into
main
Choose a base branch
from
feat/add-http-method-matching
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 95.41% 96.15% +0.74%
==========================================
Files 4 4
Lines 414 494 +80
Branches 79 94 +15
==========================================
+ Hits 395 475 +80
Misses 19 19
|
pi0
reviewed
Jul 29, 2023
pi0
reviewed
Jul 29, 2023
Hebilicious
force-pushed
the
feat/add-http-method-matching
branch
from
July 30, 2023 06:35
0b7074e
to
8b8474d
Compare
@pi0 Refactored according to your instructions, added benchmarks and more tests. |
1 task
Hebilicious
force-pushed
the
feat/add-http-method-matching
branch
from
September 2, 2023 10:52
d2ae01d
to
9c87773
Compare
Hebilicious
changed the title
feat: add http method matching
feat!: add http method matching
Sep 2, 2023
@pi0 Just revisiting this PR. I simplified it, rebased and added a description, as well as flagged it as a breaking change due to the |
Put a pending label i need to still benchmark and validate it more. |
This was referenced Sep 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #58
β Type of change
π Description
This PR adds a new syntax to allow http method to be matched with radix3.
The current implementation contains a (small) breaking to
staticRoutesMap
, which is now a 2 dimensional array to support fast method matching. A one dimensional approach is possible, but not as robust as the 2 dimensional one #59 (comment).π Checklist