Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routeRules are case sensitive #2234

Open
pi0 opened this issue Mar 8, 2024 · 2 comments
Open

routeRules are case sensitive #2234

pi0 opened this issue Mar 8, 2024 · 2 comments
Labels

Comments

@pi0
Copy link
Member

pi0 commented Mar 8, 2024

extracted from #2146

Likewise, routeRules are case sensitive. In your example, requesting /Support-Me will not redirect either. However, URIs should be case insensitive.

Let me know if this needs a separate issue. I figure it's so closely related it might make sense to tackle them together. Vue-Router addresses them together in the documentation.

Originally posted by @lwpinion in #2146 (comment) /cc @lpinion-ew

@pi0
Copy link
Member Author

pi0 commented Mar 8, 2024

According to both RFC 3986 / WHATWG standards, URL path is case sensitive by default, which means /path and /Path are different.

We can introduce a new sensitive: false route rule meta but it also means we need to add extra runtime overhead for checking incoming URL against route rules twice + we diverge from Web standards.

@lwpinion
Copy link

lwpinion commented Mar 8, 2024

According to both RFC 3986 / Whatwg standards, URL path is case sensitive by default, which means /path and /Path are different.

This issue may not be entirely related, but this definitely seems to be an ongoing and divisive conversation across the ecosystem:
vuejs/vue-router#1214

That being said, I can definitely understand any hesitancy since this would add runtime overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants