Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sorting adjectives #14

Open
grhoten opened this issue Mar 14, 2024 · 1 comment
Open

Add support for sorting adjectives #14

grhoten opened this issue Mar 14, 2024 · 1 comment
Labels
discuss Discussion item

Comments

@grhoten
Copy link
Member

grhoten commented Mar 14, 2024

This is mostly an English topic, but it can be helpful in other languages. A more detailed discussion of the issue can be found here: https://en.wikipedia.org/wiki/Adjective#Order

When adding a list of adjectives to a noun, there is typically an order to the adjectives. When they're in the wrong order, the message can be awkward.

For example, in English, you would want to be able to say "old French animated movies" instead of "animated French old movies". There's a lot of other examples, but the point is that there is an implicit order in English. Adding metadata that is similar to what is listed in the Wikipedia article would be sufficient.

@grhoten grhoten added the discuss Discussion item label Mar 14, 2024
@nciric
Copy link
Contributor

nciric commented Mar 18, 2024

So this is a question of providing lexicon info with the adjective?

Is the expectation for our logic to sort adjectives given the lexicon info? I don't see a strong use case for that in the current localization:

  1. Messages are usually created in English, and adjective order is already correct
  2. Translators can fix the order as needed.

Do you envision a case where we drop a number of adjectives into a placeholder/sentence and expect algorithm to sort it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Discussion item
Projects
Status: In Progress
Development

No branches or pull requests

2 participants