Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reexporting properties::props items in 2.0 #6047

Open
cmyr opened this issue Jan 29, 2025 · 2 comments
Open

Consider reexporting properties::props items in 2.0 #6047

cmyr opened this issue Jan 29, 2025 · 2 comments
Labels
C-unicode Component: Props, sets, tries

Comments

@cmyr
Copy link
Contributor

cmyr commented Jan 29, 2025

A quick note that while upgrading from 1.x to 2.x one change I had to address was that a lot of items that were previously available in the properties module (such as Script and BidiClass) are now in properties::props. Unless there's some compelling reason I'm missing, I think it makes sense to have these items available in the root properties module? It would make the upgrade experience cleaner for folks, and also provide a generally cleaner API.

@sffc sffc added the C-unicode Component: Props, sets, tries label Jan 31, 2025
@sffc
Copy link
Member

sffc commented Jan 31, 2025

This was discussed in #3573 and implemented in #5548

In general it makes the crate more organized for all property enums to be in a module together props, since icu_properties exports a bunch of other types for reading the properties. It is nice to see a list in one place.

CC @Manishearth @robertbastian Should we revisit this?

@Manishearth
Copy link
Member

@cmyr The root of the module gets messy otherwise, we want it to have the main dataful types provided by the crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-unicode Component: Props, sets, tries
Projects
None yet
Development

No branches or pull requests

3 participants