Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end-to-end not exiting on fatal Rust executor errors #52

Open
1 of 2 tasks
echeran opened this issue Mar 21, 2023 · 0 comments
Open
1 of 2 tasks

end-to-end not exiting on fatal Rust executor errors #52

echeran opened this issue Mar 21, 2023 · 0 comments
Assignees
Labels
bug Something isn't working related to CI or the framework as a whole

Comments

@echeran
Copy link
Collaborator

echeran commented Mar 21, 2023

The Rust executor is getting an error when trying to execute sendOneLine, and it does so for every batch of 10,000 tests that it sends.

Ex:

Testing ../executors/rust/target/release/executor / coll_shift_short. 190,000 of 192,707
Testing ../executors/rust/target/release/executor / coll_shift_short. 191,000 of 192,707
Testing ../executors/rust/target/release/executor / coll_shift_short. 192,000 of 192,707
!!! sendOneLine fails: input => {"label": "0190000", "string1": "\u2eb6!", "string2": "\u2eb6?", "test_type": "coll_shift_short"}
{"label": "0190001", "string1": "\u2eb6?", "string2": "\u2eb7!", "test_type": "coll_shift_short"}
...
#EXIT<. Err = [Errno 2] No such file or directory: '../executors/rust/target/release/executor'
!!!!!! processBatchOfTests: "platform error": "None"

Issues:

  • The Python script running everything logs the entire batch of test cases upon this error. We shouldn't print those 10000 lines
  • In cases where the Python script can't get the executors to do basic things properly, the Python script should exit with a non-zero exit code

Bonus points: in the future, we can use a logging library so that we can more easily control the behavior differently on our local machines vs. on CI

@sffc sffc added this to the 2024 Q4 ⟨P1⟩ milestone Nov 18, 2024
@sven-oly sven-oly added the bug Something isn't working related to CI or the framework as a whole label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working related to CI or the framework as a whole
Projects
None yet
Development

No branches or pull requests

3 participants