Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative Date Time Format tests not using ICU76 / CLDR 46 data #382

Open
sven-oly opened this issue Jan 10, 2025 · 3 comments
Open

Relative Date Time Format tests not using ICU76 / CLDR 46 data #382

sven-oly opened this issue Jan 10, 2025 · 3 comments
Assignees

Comments

@sven-oly
Copy link
Collaborator

sven-oly commented Jan 10, 2025

The same 30 tests are failing in the public dashboard for RDTF, e.g., ICU4C rdtf, and also ICU4J and Node JS.
image

These should have been fixed with the updated test generator in PR #378. This works well when running the tests on my local machine, as shown here:
image

The difference is that the public page is not using the updated CLDR data.

Note that the RDTF tests are created from NodeJS, and PR #378 updated that generator to use NodeJS 23.3.

Why is the public page not generating the data correctly? Is something missing in the configuration for the continuous integration?

@sven-oly
Copy link
Collaborator Author

Note that this would also fix some of the ICU4X RDTF test failures in 2.0 Beta version.

@sffc
Copy link
Member

sffc commented Jan 13, 2025

Craig fixed this locally but it is not working yet in CI.

@sffc sffc added this to the 2025 Q1 ⟨P1⟩ milestone Jan 13, 2025
@sven-oly
Copy link
Collaborator Author

This still seems to be a problem, although a PR was submitted to use nvm run in the test generation step. Why is this not working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants