Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing [global::Microsoft.OData.Client.ContainerProperty] on DynamicProperties #79

Closed
MarkusBux opened this issue May 16, 2022 · 2 comments · May be fixed by #80
Closed

Missing [global::Microsoft.OData.Client.ContainerProperty] on DynamicProperties #79

MarkusBux opened this issue May 16, 2022 · 2 comments · May be fixed by #80
Labels
bug Something isn't working

Comments

@MarkusBux
Copy link

Describe the bug

Creating an OData Client which uses open types / dynamic properties, does generate the property, but does not put the [global::Microsoft.OData.Client.ContainerProperty] attribute on it. Therefore, it is not used as container property.

Assemblies affected

n/a

Steps to reproduce

  1. Create an OData client of a service that uses open types
  2. Query the type
  3. Verify that the dynamic properties are not loaded
    ...

Expected result

Open type / dynamic properties are loaded into the Dictionary<string, object>

Actual result

Open type / dynamic properties are not loaded into the Dictionary<string, object>

Screenshots

'-

Additional detail

'-
@MarkusBux MarkusBux added the bug Something isn't working label May 16, 2022
@MarkusBux MarkusBux mentioned this issue May 16, 2022
Open
@VatroslavSrzic
Copy link

Any chance of providing this fix any time soon.

@unchase
Copy link
Owner

unchase commented Apr 1, 2023

Hi, @MarkusBux @VatroslavSrzic

This functionality probably was implemented in OdataConnectedService
I recommend using this solution, as I support it to a greater extent.

You can also propose a PR with changes.

@unchase unchase closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Fix for OpenTypeProperties MarkusBux/Unchase.Odata.Connectedservice
3 participants
@VatroslavSrzic @unchase @MarkusBux