-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline-facets don't include missing dates automatically #23
Comments
After discussion with @darionco it was decided that this improvement should be made as a plugin for a few reasons: |
Proposed solution: make a plugin for SmartTimelineFacet |
I'm not entirely sure that this is a strictly necessary improvement but it feels like it a useful additional feature If you omit a row of data provided to timeline facet, the facet simply skips over that date rather than including it as empty.
My thinking is that a timeline should always include missing days or months as empty automatically rather than trusting the user to fill in every date. If a user doesn't want to fill in every date then they would be simply using a normal bars facet rather than a timeline.
The text was updated successfully, but these errors were encountered: