Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all types to export on same line #440

Open
mj3cheun opened this issue Sep 3, 2021 · 1 comment
Open

Refactor all types to export on same line #440

mj3cheun opened this issue Sep 3, 2021 · 1 comment
Labels

Comments

@mj3cheun
Copy link
Contributor

mj3cheun commented Sep 3, 2021

@RosaRomeroGomez and @YohannParis, opinions on export on same line vs at bottom? i personally prefer same line but we should probably make it consistent either way.

@YohannParis
Copy link
Contributor

I personally like it at the bottom so that is easier to set them up, rename them etc. Because not all functions or constants in a file will be exported.

But in the end, I agree that being consistent is more important. So I'll say go with what's easier/fastest for you.

i.e.

// All the functions
[...]

// Exports
export { 
  myFunction as default, // export feature declared earlier as default
  myFunction as function1, // rename exports to avoid naming conflicts
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants