Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor store code #439

Open
mj3cheun opened this issue Sep 2, 2021 · 0 comments
Open

Refactor store code #439

mj3cheun opened this issue Sep 2, 2021 · 0 comments
Labels

Comments

@mj3cheun
Copy link
Contributor

mj3cheun commented Sep 2, 2021

Right now, the store uses hacks to tell the store when certain values are updated. Not only is this fragile and messy, often it doesn't work properly causing friction when developing components using the store and certain hacks such as cloning objects to change the object pointer are both slow inherently and force way more reactive updates than is absolutely necessary.

To solve this issue, the store could be restructured to avoid deep nesting using for example:
https://github.com/paularmstrong/normalizr

Either that or find a predictable, dependable way of to make and track changes in deep nested objects/arrays

The following depends on #152.
If we can move to Vue 3 then we can also update the stores to use JS Map and Set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant