Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkset errors #272

Closed
philarcher opened this issue Feb 2, 2025 · 4 comments
Closed

Linkset errors #272

philarcher opened this issue Feb 2, 2025 · 4 comments
Assignees
Labels
Identity Resolver Issues related to Identifiers and resolvers

Comments

@philarcher
Copy link
Contributor

The Versioned Targets section of the IDR spec has important errors in the example linksets.

Below the anchor, the next level down is the link relation. This is either an IANA-registered link relation or a URI. It is not an array.

The confusion arises because in an HTML hyperlink you can indeed provide a white space separated list of relations, but not in a linkset.

To support the concepts of version targets we might want to introduce link types for 'latest version' and 'immutable version'? Eiher way, that section needs thinking about

@philarcher philarcher added the Identity Resolver Issues related to Identifiers and resolvers label Feb 2, 2025
@philarcher
Copy link
Contributor Author

The same problem applies to the section about creating new links. The linkset is mal-formed.

@philarcher
Copy link
Contributor Author

And the secure targets section.

@onthebreeze
Copy link
Contributor

From what I can see here - https://datatracker.ietf.org/doc/rfc9264/ the thing below anchor is an array but the property name must either be an IANA link relation name a custom link relation name (URI or CURIE). Will change it to be compliant - BUT this does feel like an error in the logical model of IETF linksets. Any given target can logically have several relationships to the anchor - for example the target can be both a product-passport and a predecessor-version. The current model doesnt seem to allow this. Unless we pick one link relation for the property name below the anchor and then put any others in a rel property of the anchor - something like the second link below.

{
    "linkset": [
        {
            "anchor": "https://resolver.sample-register.example/products/ABCD9876",
            "untp:dpp": [
                {
                    "href": "https://sample-credential-store.example/credentials/dpp/90664869327.json",
                    "title": "Digital Product Passport",
                    "hreflang":["en"],
                    "type": "application/vc+jwt"
                 },
                {
                    "href": "https://sample-credential-store.example/credentials/dpp/90664869111.json",
                    "rel":["predecessor-version"],
                    "title": "Digital Product Passport",
                    "hreflang":["en"],
                    "type": "application/vc+jwt"
                 }
            ]
        }
    ]
} 

@onthebreeze
Copy link
Contributor

OK to close this? noting separate discussion on link type registration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Identity Resolver Issues related to Identifiers and resolvers
Projects
None yet
Development

No branches or pull requests

2 participants