Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move advanced config to separate module #284

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mmalenic
Copy link
Member

Closes #283

Refactor

  • Configuration like regex-based storage locations has been moved to the advanced module inside config.
  • Config doesn't use flatten anymore, which means that . needs to be used to separate nested values. Environment variables still use _.
  • Renaming some values:
    • Local config is now called File.
    • Storage is called Backend. The tag type is now kind instead of backend.
    • C4GH config has keys.private and keys.public instead of private_key and recipient_public_key. The tag type for the key locations is also kind.
    • Resolvers are now Locations.
  • File config only inherits scheme and authority values from the data_server now. It does not inherit the local_path.
  • Data server doesn't use data prefix anymore, which makes the mapping between the initial request and URL tickets clearer.
  • Removed use_data_server and data_server_path_prefix. use_data_server = false has been replaced with data_server = "None".

Fix

  • Service info config can accept arbitrary json values.
  • The "type" field in service info is not configurable.

Build

  • Removed clippy from pre-commit as it can be quite slow.

@mmalenic mmalenic self-assigned this Dec 18, 2024
@mmalenic mmalenic added the refactor changes related to code refactoring label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor changes related to code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: service info type should be non-configurable
1 participant