Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish NPM package for deployment #270

Open
wants to merge 68 commits into
base: main
Choose a base branch
from
Open

Conversation

brainstorm
Copy link
Member

Fixes #269

brainstorm and others added 30 commits October 11, 2024 16:25
% npm install $HOME/dev/umccr/htsget-rs/deploy/
npm error Invalid Version: 1.0
Removing unnecessary BAM symlinks under crypt4gh data.

Co-authored-by: Marko Malenic <[email protected]>
fix(deploy): allow fetching C4GH and regular files
… one... this setting should probably be called 'usePreExistingHostedZone' I reckon?
% npm install $HOME/dev/umccr/htsget-rs/deploy/
npm error Invalid Version: 1.0
@brainstorm brainstorm marked this pull request as ready for review October 22, 2024 02:00
brainstorm and others added 9 commits October 28, 2024 11:56
… perhaps we should parametrise those secret manager paths if they are not already @mmalenic?
…the full non-functional refactoring route.

Co-authored-by: Marko Malenic <[email protected]>
* Use package.json "files" directive to whitelist what to publish to npmjs.com.
* Comment examples on settings.js and cleanup to guide user with settings (especially cognito ones)
* Shipping example deploy config, needs to be migrated to stack directives and the following warnings must be addressed:

npm warn package-json [email protected] No bin file found at bin/htsget-lambda.js
npm warn package-json [email protected] No bin file found at bin/htsget-lambda.js
npm warn package-json [email protected] No bin file found at bin/htsget-lambda.js
npm warn package-json [email protected] No bin file found at bin/htsget-lambda.js
…construct, we'll eventually split this deploy folder into a separate repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: publish htsget deployment to NPM
2 participants