Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: value.trim is not a function #2566

Closed
XioNoX opened this issue Mar 11, 2025 · 3 comments · Fixed by #2567
Closed

TypeError: value.trim is not a function #2566

XioNoX opened this issue Mar 11, 2025 · 3 comments · Fixed by #2567
Labels

Comments

@XioNoX
Copy link

XioNoX commented Mar 11, 2025

Describe the bug
One remote data layer stopped working on one of my maps. Console shows this error :

TypeError: value.trim is not a function
    getDisplayName features.6c66fdaefab0.js:118
    resetTooltip ui.a8c11b394c36.js:16
    _initIcon ui.a8c11b394c36.js:48
    onAdd Marker.js:122
    onAdd ui.a8c11b394c36.js:8
    _layerAdd Layer.js:114
    whenReady Map.js:1477
    addLayer Layer.js:172
    addLayer LayerGroup.js:47
    addLayer FeatureGroup.js:35
    showFeature layer.3d76c4054553.js:159
    addFeature layer.3d76c4054553.js:167
    makeFeature layer.3d76c4054553.js:210
    makeFeatures layer.3d76c4054553.js:197
    addData layer.3d76c4054553.js:187
    fromGeoJSON layer.3d76c4054553.js:103
    fetchRemoteData layer.3d76c4054553.js:140
    promise callback*fetchRemoteData/< layer.3d76c4054553.js:140
    promise callback*fetchRemoteData layer.3d76c4054553.js:139
    edit layer.3d76c4054553.js:298
    handler DomEvent.js:108
    addOne DomEvent.js:135
    on DomEvent.js:34
    createButton umap.core.fde9dc51a802.js:23
    edit layer.3d76c4054553.js:298
    handler DomEvent.js:108
    addOne DomEvent.js:135
    on DomEvent.js:34
    renderToolbox layer.3d76c4054553.js:456
    editDatalayers umap.292a6eb8fbfb.js:527
    eachDataLayerReverse umap.292a6eb8fbfb.js:515
    editDatalayers umap.292a6eb8fbfb.js:525
    setup bar.f9aa67a56025.js:139
    _onClick bar.f9aa67a56025.js:160
    setup bar.f9aa67a56025.js:139
    init umap.292a6eb8fbfb.js:77
    Umap umap.292a6eb8fbfb.js:31
    <anonymous> saint-pierre_1067410:280
layer.3d76c4054553.js:188:9
    addData layer.3d76c4054553.js:188
    fromGeoJSON layer.3d76c4054553.js:103
    fetchRemoteData layer.3d76c4054553.js:140
    (Async: promise callback)
    fetchRemoteData layer.3d76c4054553.js:140
    (Async: promise callback)
    fetchRemoteData layer.3d76c4054553.js:139
    edit layer.3d76c4054553.js:298
    handler DomEvent.js:108
    (Async: EventListener.handleEvent)
    addOne DomEvent.js:135
    on DomEvent.js:34
    createButton umap.core.fde9dc51a802.js:23
    edit layer.3d76c4054553.js:298
    handler DomEvent.js:108
    (Async: EventListener.handleEvent)
    addOne DomEvent.js:135
    on DomEvent.js:34
    renderToolbox layer.3d76c4054553.js:456
    editDatalayers umap.292a6eb8fbfb.js:527
    eachDataLayerReverse umap.292a6eb8fbfb.js:515
    editDatalayers umap.292a6eb8fbfb.js:525
    setup bar.f9aa67a56025.js:139
    (Async: EventListener.handleEvent)
    _onClick bar.f9aa67a56025.js:160
    setup bar.f9aa67a56025.js:139
    init umap.292a6eb8fbfb.js:77
    Umap umap.292a6eb8fbfb.js:31
    <anonymous> saint-pierre_1067410:280

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://umap.openstreetmap.fr/fr/map/saint-pierre_1067410
  2. See error (and the data not loading, while querying manually the remote URL returns the proper json

Expected behavior
Show the data from the remove geojson

Desktop (please complete the following information):

  • OS: Ubuntu 24.10
  • Firefox 135
  • Chrome 125

Thanks

@XioNoX XioNoX added the bug label Mar 11, 2025
@yohanboniface
Copy link
Member

Thanks for the report and the reproductible case, I'll have a look!

@XioNoX
Copy link
Author

XioNoX commented Mar 12, 2025

@yohanboniface awesome thanks! any idea when it will be live on the https://umap.openstreetmap.fr ?

@davidbgk
Copy link
Contributor

@XioNoX when a new release will be issued https://github.com/umap-project/umap/releases (no estimate at that point)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants