-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caption popup: too much spacing when using the # markup. #1854
Labels
Comments
yohanboniface
added a commit
that referenced
this issue
May 29, 2024
Basically, we do not add `<br>` anymore, but instead let the newline and use the css `white-space: pre-line;`. Also remove new lines after title. While doing that change, I needed to reorder regex so the ones needing a newline before would still have it (bullets points). I've added tests and removed some to cover those changes. fix #1854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
There is too much spacing in the caption popup when using the # markup.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
More proportional spacing expected as shown in preferred version at bottom
Screenshots
![image](https://private-user-images.githubusercontent.com/267163/332984138-ede82575-4617-464c-b756-da2151eb7f5b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxMDQ2MDEsIm5iZiI6MTcxOTEwNDMwMSwicGF0aCI6Ii8yNjcxNjMvMzMyOTg0MTM4LWVkZTgyNTc1LTQ2MTctNDY0Yy1iNzU2LWRhMjE1MWViN2Y1Yi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyM1QwMDU4MjFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00ZGNiZDk3OTgzMjYzOGIyZTFiYzg1MzU5ZjMzNzM2MWEzODkwMmFhMDRiYmE2ODhlZWZkMjI3MTUxN2Q0ZThjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.AZE1Y39KA2RuEeevpB_vkysalgLSBBGI0fcaDWKVHHE)
Desktop (please complete the following information):
Additional context
The popup underlying template is as such:
It appears the code is using
<br>
elements to implement line breaks. However the # markup also calls for<h3>
, hence the final code has<h3><br>
which creates a double line break, hence the extra space. Also line height for<h3>
is set to 3.I have removed the extra
<br>
below<h3>
and set line-height to 1.75 in my preferred version belowThe text was updated successfully, but these errors were encountered: