[NODRIVER] NameError: name 'items' is not defined in async select method

[khamaileon]

Description:
When using the select method, a NameError is raised:

NameError: name 'items' is not defined. Did you mean: 'item'?

  async def select(
      self,
      selector: str,
      timeout: Union[int, float] = 10,
  ) -> nodriver.Element:
      """
      find single element by css selector.
      can also be used to wait for such element to appear.

      :param selector: css selector, eg a[href], button[class*=close], a > img[src]
      :type selector: str

      :param timeout: raise timeout exception when after this many seconds nothing is found.
      :type timeout: float,int

      """
      loop = asyncio.get_running_loop()
      start_time = loop.time()

      selector = selector.strip()
      item = await self.query_selector(selector)

      while not item:
          await self
          item = await self.query_selector(selector)
          if loop.time() - start_time > timeout:
              return items
          await self.sleep(0.5)
      return item

Steps to Reproduce:

1. Call the select method with a CSS selector and a timeout value.
2. Ensure that no matching element appears within the timeout period.
3. Observe the NameError when the return items line is executed.

Expected Behavior:
The method should raise an appropriate exception if no matching element is found within the timeout period.

Actual Behavior:
The method raises a NameError because the variable items is not defined.

[stephanlensky]

Hey @khamaileon, I created a fork of nodriver here stephanlensky/zendriver which fixes this and other bugs, feel free to take a look.

[khamaileon]

I can confirm that the problem is resolved with Zendriver.

[mdmintz]

You can find a fix to that and other nodriver issues in https://github.com/seleniumbase/SeleniumBase.

Includes a PyAutoGUI integration for advanced clicking. Eg: sb.cdp.gui_click_element(selector)

Here's a sample script that scrapes the Nike website for shoe prices:

from seleniumbase import SB

with SB(uc=True, test=True, locale_code="en", ad_block=True) as sb:
    url = "https://www.nike.com/"
    sb.activate_cdp_mode(url)
    sb.sleep(2.5)
    sb.cdp.gui_click_element('div[data-testid="user-tools-container"]')
    sb.sleep(1.5)
    search = "Nike Air Force 1"
    sb.cdp.press_keys('input[type="search"]', search)
    sb.sleep(4)
    elements = sb.cdp.select_all('ul[data-testid*="products"] figure .details')
    if elements:
        print('**** Found results for "%s": ****' % search)
    for element in elements:
        print("* " + element.text)
    sb.sleep(2)

Or if you prefer async / await, you can use that format instead. Eg:

import asyncio
import time
from seleniumbase.undetected import cdp_driver

async def main():
    driver = await cdp_driver.cdp_util.start_async()
    page = await driver.get("https://www.priceline.com/")
    time.sleep(3)
    print(await page.evaluate("document.title"))
    element = await page.select('[data-testid*="endLocation"]')
    await element.click_async()
    time.sleep(1)
    await element.send_keys_async("Boston")
    time.sleep(2)

if __name__ == "__main__":
    loop = asyncio.new_event_loop()
    loop.run_until_complete(main())