Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the library ready for Python 3.7, 3.8, 3.9 and 3.10 #26

Open
dprada opened this issue Aug 1, 2022 · 3 comments
Open

Making the library ready for Python 3.7, 3.8, 3.9 and 3.10 #26

dprada opened this issue Aug 1, 2022 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@dprada
Copy link
Collaborator

dprada commented Aug 1, 2022

Python 3.7 expires in 11 months (27 Jun 2023). So, it is probably time to prepare PyUnitWizard for later Python versions (3.8, 3.9, and 3.10). Another good reason to do it is that newer versions are faster.

Although the typical suggestion is to give support to the last three Python versions, from now on we will try to keep the library available for every supported version: 3.7, 3.8, 3.9, and 3.10 (at the current moment).

@dprada dprada added bug Something isn't working enhancement New feature or request labels Aug 1, 2022
@dprada dprada added this to the 0.6.3 milestone Aug 1, 2022
@dprada dprada self-assigned this Aug 1, 2022
@dprada
Copy link
Collaborator Author

dprada commented Aug 1, 2022

Some tests fail due to different reasons.

Tests with Python 3.7 fail

There is a SyntaxisError in unyt with Python 3.7. Let's see if this is solved in the future. At this point let's take the following actions:

  • we will skip tests with Python 3.7.
  • since unyt is a suggested but not required package, we won't cancel the building of conda packages for Python 3.7

Test with Python 3.10 and macos-latest fails

There is a problem with openmm in this case:

Encountered problems while solving:
    - package openmm-7.6.0-py36he516fd0_0_apple requires python >=3.6,<3.7.0a0, but none of the providers can be installed

At this point let's take the following actions:

  • Let's cancel provisionally this test.
  • since openmm is a suggested but not required package, we won't cancel the building of conda package in this case

All tests with windows-latest fail

There is an error with openmm and windows:

_______________ ERROR collecting pyunitwizard/tests/test_get.py _______________
pyunitwizard\forms\api_openmm_unit.py:6: in <module>
    import openmm.unit as openmm_unit
C:\Miniconda\envs\test\lib\site-packages\openmm\__init__.py:19: in <module>
    from openmm.openmm import *
C:\Miniconda\envs\test\lib\site-packages\openmm\openmm.py:13: in <module>
    from . import _openmm
E   ImportError: DLL load failed while importing _openmm: The specified module could not be found.

At this point let's take the following actions:

  • Let's cancel provisionally this test.
  • since openmm is a suggested but not required package, we won't cancel the building of conda package in this case

@dprada
Copy link
Collaborator Author

dprada commented Aug 1, 2022

Error building packages with Python 3.10

There is an error building packages with Python 3.10.:

  ValueError: Incompatible component merge:
    - 'mpi_mpich_*'
    - 'mpi_mpich_tempest*'
  Error: Process completed with exit code 1.

The error was already reported in conda/conda#11442.

@dprada
Copy link
Collaborator Author

dprada commented Aug 1, 2022

Some tests fail due to different reasons.

Tests with Python 3.7 fail

There is a SyntaxisError in unyt with Python 3.7. Let's see if this is solved in the future. At this point let's take the following actions:

  • we will skip tests with Python 3.7.
  • since unyt is a suggested but not required package, we won't cancel the building of conda packages for Python 3.7

Unyt is not longer supported for Python 3.7. We need to implement a mechanism to skip tests with unyt with this Python version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

1 participant