Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting pdf's to other gradescope assignments fails when students add in external files #764

Closed
rohanjha123 opened this issue Jan 17, 2024 · 3 comments · Fixed by #765
Closed
Labels
enhancement New feature or request
Milestone

Comments

@rohanjha123
Copy link

rohanjha123 commented Jan 17, 2024

Is your feature request related to a problem? Please describe.
Sometimes, students may add in their own .png/.jpg files into the .ipynb notebooks. When this happens, the zip (including the pdf) will generate fine in the notebook. However, when the student submits the zip to Gradescope, the pdf will not be able to be generated (as those necessary files aren't included), thus leading to an error.

Describe the solution you'd like
I would love it if any files students use in their .ipynb notebooks can be included in the generated .zip. If this isn't possible, maybe the pdf included in the zip can be sent to the other Gradescope assignment rather than recreating the pdf from scratch.

Describe alternatives you've considered
If the above options are not possible, it'd be great if students could get a warning that they have dragged in images/files which will mess up the Gradescope submission.

Additional context
I've dm'ed reproducible notebooks to Chris!

@rohanjha123 rohanjha123 added the enhancement New feature or request label Jan 17, 2024
@chrispyles chrispyles added this to the v5.3.0 milestone Jan 17, 2024
@chrispyles
Copy link
Member

chrispyles commented Jan 22, 2024

#765 adds the ability to use the submission PDF instead of generating a new one. To use it, set generate: use_submission_pdf: true in the assignment config.

@rohanjha123
Copy link
Author

Thanks sm Chris! Just to confirm, I will only be able to use this when otter 5.3 releases right? If that's the case, I will upgrade data 100 and econ 148 datahub to otter 5.3 as soon as it drops.

@chrispyles
Copy link
Member

Yes, that's correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants