Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXD-444 ⁃ support deleting property values for submitted node #9

Open
philloooo opened this issue Sep 28, 2017 · 3 comments
Open

Comments

@philloooo
Copy link
Contributor

philloooo commented Sep 28, 2017

No description provided.

@fortuno
Copy link

fortuno commented Sep 28, 2017

My suggestion would be:

  • ignore (keep previous value): if that property is not in the TSV/JSON (no header or key).
  • delete: if that property is in the submitted file (TSV/JSON) with either empty or "null" value.

@dmiller15
Copy link

Agreed with Francisco on both points. For more on the second point, I agree as long as the deletion is done through the same submission system. The ideal situation would be to create a specific deletion option of some sort. Much like what we do with the node deletion there would be some sort of interface separate from submission that would allow people to remove individual properties.

@allisonheath
Copy link

Also might consider using PATCH and PUT verbs. Where PUT fully replaces everything that was there before and PATCH just updates whatever is specified. See: https://docs.cancergenomicscloud.org/docs/overwrite-a-files-metadata

@philloooo philloooo changed the title support deleting property values for submitted node PXD-444 ⁃ support deleting property values for submitted node May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants