Introduce CompiledCGPatterns capturing the TS-Query and regex (placeholder) #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…older) [ghstack-poisoned]
ketkarameya
added a commit
that referenced
this pull request
Jul 5, 2023
…older) ghstack-source-id: cf2baf162fcbfc57e097e1fbc6e90c5ae2869b74 Pull Request resolved: #527
…gex (placeholder)" [ghstack-poisoned]
ketkarameya
added a commit
that referenced
this pull request
Jul 5, 2023
…older) ghstack-source-id: bf54c1bcedd104b1403acef426fc1a11974cd82d Pull Request resolved: #527
Merged
lazaroclapp
reviewed
Jul 7, 2023
src/models/capture_group_patterns.rs
Outdated
| } | ||
|
|
||
| impl CompiledCGPattern { | ||
| /// Applies the query upon the given node, and gets all the matches |
There was a problem hiding this comment.
Is the documentation correct here? It seems this returns 0 or 1 matches. Is this meant to be the docstring for get_matches?
…gex (placeholder)" Introduces `CompiledCGPattern` which wraps `treesitter::Query` and `regex::Regex` (A simple temporary test to show that regex support is added but not supported. This test is updated in the stacked diff). ------ [ghstack-poisoned]
…gex (placeholder)" Introduces `CompiledCGPattern` which wraps `treesitter::Query` and `regex::Regex` (A simple temporary test to show that regex support is added but not supported. This test is updated in the stacked diff). ------ [ghstack-poisoned]
Open
ketkarameya
added a commit
that referenced
this pull request
Jul 10, 2023
…older) ghstack-source-id: 0ef1c1ae7eaf0b3c2d49a0287818b1b2677b33a0 Pull Request resolved: #527
crystalninja5
added a commit
to crystalninja5/solid-tribble
that referenced
this pull request
Aug 11, 2024
…older) ghstack-source-id: 0ef1c1ae7eaf0b3c2d49a0287818b1b2677b33a0 Pull Request resolved: uber/piranha#527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
CompiledCGPatternwhich wrapstreesitter::Queryandregex::Regex(A simple temporary test to show that regex support is added but not supported. This test is updated in the stacked diff).
Stack from ghstack (oldest at bottom):