Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes extra parenthesis while refactoring conditional expressions #227

Open
himanshuguptan opened this issue Aug 30, 2022 · 3 comments
Open
Labels
legacy-java Issues/PR related to older PiranhaJava implementation

Comments

@himanshuguptan
Copy link

PIRANHA removes extra parenthesis when used as shown below in a conditional expression.
Before refactoring:

:
if (a != null && isSomeOtherCondition() && testExperiment.isTreated(STALE_FLAG)) {
 :
}
:

After refactoring:

:
if a != null && isSomeOtherCondition() {
 :
}
:
@ketkarameya
Copy link
Collaborator

ketkarameya commented Sep 2, 2022

Hey @himanshuguptan ! Thanks for reporting this. I was wondering if you mind trying the polyglot piranha version ? We are actively developing that project. It has support for Java, Kotlin and we have plans to support many other languages on that framework.

@ketkarameya ketkarameya added the legacy-java Issues/PR related to older PiranhaJava implementation label Sep 2, 2022
@ketkarameya ketkarameya changed the title [PiranhaJava] Removes extra parenthesis while refactoring conditional expressions Removes extra parenthesis while refactoring conditional expressions Sep 2, 2022
@himanshuguptan
Copy link
Author

Hi @ketkarameya , thanks for replying. We have already integrated with the regular Piranha version for now and were looking for support for these bugs. Any timelines for the fix?

Also, for the polyglot piranha through Python library, I see that the project 'polyglot-piranha' version '0.1.2' has no published source distribution(sdist) on Pypi.org. Our organization currently does not allow for installing such packages without sdists and using a binary wheel. Any reasons for doing so? Can you publish the sdist for the package?

Once that is done, we could possibly explore the polyglot version as well.

@ketkarameya
Copy link
Collaborator

ketkarameya commented Sep 15, 2022

Hey @himanshuguptan we don't really plan to keep actively maintaining the piranha/java. We are trying to get everyone onboarded onto Polyglot Piranha.

About the sdist : Yea I will add it to the next release. I will add it to the Github workflow that publishes the release (I missed it).
Until then, I would recommend getting started with the demos. Getting started with demos will not require pypi dependency, so I think you could start experimenting.

I will make the next release next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-java Issues/PR related to older PiranhaJava implementation
Projects
None yet
Development

No branches or pull requests

2 participants