Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lint] Lint should not depend on compilation #791

Open
ZacSweers opened this issue Jan 8, 2019 · 4 comments
Open

[Lint] Lint should not depend on compilation #791

ZacSweers opened this issue Jan 8, 2019 · 4 comments

Comments

@ZacSweers
Copy link
Contributor

It runs on ASTs, so it can run in parallel to compilation.

As a potential followup, we can maybe look at making lint optionally run as an implicit concurrent action of building a src target

@ZacSweers
Copy link
Contributor Author

ZacSweers commented Jan 8, 2019

It looks like this is partially done via removing --classpath in #742, but is there anything else needed for regular genrule ordering? Per the internal ticket this seemed to not be done yet, but unsure where else to look

@kageiit
Copy link
Contributor

kageiit commented Jan 8, 2019

The issue is that buck puts the output of the target itself as part of the classpath which means it is still building the target when we dont want it to. We need to make a change to buck to allow a classpath_without_self kind of macro option to get it to do what we want

@ZacSweers
Copy link
Contributor Author

ZacSweers commented Jan 8, 2019

Is there an upstream issue we can link?

@kageiit
Copy link
Contributor

kageiit commented Jan 8, 2019

Dont think we made one. @raviagarwal7 was going to look into it at some point iirc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants