Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the registry backend able to handle V1 manifest responses #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wk8
Copy link

@wk8 wk8 commented Oct 28, 2020

With a unit test.

Fixes #288

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.02 ⚠️

Comparison is base (e435b83) 64.80% compared to head (90f69bd) 64.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   64.80%   64.79%   -0.02%     
==========================================
  Files         186      186              
  Lines        7822     7825       +3     
==========================================
+ Hits         5069     5070       +1     
- Misses       1999     2000       +1     
- Partials      754      755       +1     
Impacted Files Coverage Δ
lib/backend/registrybackend/tagclient.go 59.72% <80.00%> (+1.75%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails for some repositories with quay.io as a registry backend
1 participant