Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: uber-go/goleak
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.0
Choose a base ref
...
head repository: uber-go/goleak
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 11 commits
  • 10 files changed
  • 5 contributors

Commits on Apr 13, 2024

  1. gracefully handle elided frames (#120)

    When parsing stacks we frequently encounter elided frames. The actual
    stack line looks something like `...23 frames elided...`, which is
    passed to `parseFuncName`, which of course is not parsable as a function
    name. As a result, whenever this happens we get a useless panic like the
    following:
    
    ```
    panic: Failed to parse stack trace: parse function: no function found: "...23 frames elided..."
    goroutine 1 [running]:
    go.uber.org/goleak/internal/stack.getStackBuffer(0x1)
    	/home/runner/go/pkg/mod/go.uber.org/goleak@v1.3.0/internal/stack/stacks.go:240 +0x65
    go.uber.org/goleak/internal/stack.getStacks(0x1)
    	/home/runner/go/pkg/mod/go.uber.org/goleak@v1.3.0/internal/stack/stacks.go:84 +0x3b
    go.uber.org/goleak/internal/stack.All(...)
    	/home/runner/go/pkg/mod/go.uber.org/goleak@v1.3.0/internal/stack/stacks.go:229
    go.uber.org/goleak.Find({0xc0003ae880, 0x4, 0x4})
    	/home/runner/go/pkg/mod/go.uber.org/goleak@v1.3.0/leaks.go:65 +0x1ea
    ```
    
    This PR gracefully handles elided frames to prevent the panic.
    drshriveer authored Apr 13, 2024
    Copy the full SHA
    b62053b View commit details
  2. Fix lint and upgrade versions to 1.21/1.22 (#121)

    Follow-up to #120, I accidentally merged the PR without waiting for all
    tests to run, and missed that 1.20 tests are failing.
    
    Lint is failing because of how we skip golangci-lint run in the action
    and use the Makefile. Use the same logic as zap to skip lint.
    
    Tests are failing on 1.20 as stack elision doesn't kick in for the test.
    From 1.21 onwards, it does kick in. Rather than try to make the test
    trigger stack elision on 1.20, let's bump the versions to 1.21 / 1.22.
    prashantv authored Apr 13, 2024
    Copy the full SHA
    c87aef9 View commit details

Commits on Apr 29, 2024

  1. CI: Upgrade to codecov 4 & use token.

    This upgrades codecov CI action to version 4,
    and uses the codecov token when uploading,
    since tokenless uploading is no longer supported for some cases.
    JacobOaks committed Apr 29, 2024
    Copy the full SHA
    039f6e4 View commit details
  2. CI: Upgrade to codecov 4 & use token. (#122)

    This upgrades codecov CI action to version 4,
    and uses the codecov token when uploading,
    since tokenless uploading is no longer supported for some cases.
    JacobOaks authored Apr 29, 2024
    Copy the full SHA
    517bace View commit details

Commits on Jun 5, 2024

  1. update golangci-lint configuration (#124)

    This add explicit exemption for things we don't care about in errcheck
    lint message.
    sywhang authored Jun 5, 2024
    Copy the full SHA
    7f1444f View commit details
  2. Remove no longer needed tracestack_new.go file (#123)

    The PR moves `isTraceStack` from the `tracestack_new.go` to
    `options.go`. The file `tracestack_new.go` became unnecessary after #79.
    alexandear authored Jun 5, 2024
    Copy the full SHA
    3b6d3dd View commit details

Commits on Jun 6, 2024

  1. README: replace deprecated godoc links with new ones (#125)

    This PR replaces the deprecated `GoDoc` links with new ones to `Go
    Reference` in `README.md`.
    
    See golang/go#49212 for details about the
    deprecated `godoc`.
    The badge is created at https://pkg.go.dev/badge/.
    alexandear authored Jun 6, 2024
    Copy the full SHA
    4b71e24 View commit details

Commits on Jun 7, 2024

  1. Copy the full SHA
    898a938 View commit details

Commits on Oct 1, 2024

  1. Add RunOnFailure option (#129)

    This adds an Option to run goleak when test runs fail.
    
    Fixes #128.
    sywhang authored Oct 1, 2024
    Copy the full SHA
    7452c70 View commit details
  2. Copy the full SHA
    79b1d32 View commit details

Commits on Nov 21, 2024

  1. clarify README (#134)

    someone at Uber unfortunately spent cycles trying to convert
    VerifyTestMain call to VerifyNone(t) for individual cases only to find
    out that it doesn't work well with t.Parallel().
    
    Even though VerifyNone(t)'s documentation already says this, it might be
    worth clarifying this in the README since the wording can make it sound
    like calling VerifyTestMain() vs calling VerifyNone() at the end of
    every single test case is completely identical in behavior.
    sywhang authored Nov 21, 2024
    Copy the full SHA
    4ff5fa6 View commit details
Loading