Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI/CD more secure #783

Open
wwarriner opened this issue Aug 16, 2024 · 1 comment
Open

Make CI/CD more secure #783

wwarriner opened this issue Aug 16, 2024 · 1 comment
Labels
dev: enhancement Enhancement to docs machinery (extensions, ci/cd, etc)

Comments

@wwarriner
Copy link
Contributor

Use this: https://github.com/marketplace/actions/deploy-mkdocs

Use a GitHub Token to and make gh-pages a protected branch only the bot can access.
@wwarriner wwarriner added the dev: enhancement Enhancement to docs machinery (extensions, ci/cd, etc) label Aug 16, 2024
@wwarriner
Copy link
Contributor Author

Not feasible at this time due to security implications of current github permissions framework. The closest I can get is

(1) Trust the team to never merge PRs to gh-pages directly
(2) Restrict approve/request changes reviews to explicitly-added collaborators, i.e., our team. So no "drive by" PR + review combos. This is done on this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev: enhancement Enhancement to docs machinery (extensions, ci/cd, etc)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wwarriner