Skip to content
This repository has been archived by the owner on Sep 19, 2020. It is now read-only.

Save image in Google image search doesn't work (with workaround) #234

Open
3 of 9 tasks
Shudushi opened this issue Mar 7, 2020 · 12 comments
Open
3 of 9 tasks

Save image in Google image search doesn't work (with workaround) #234

Shudushi opened this issue Mar 7, 2020 · 12 comments
Labels
external an external factor is involved something to address something to address

Comments

@Shudushi
Copy link

Shudushi commented Mar 7, 2020

Prerequisites

  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • This is not a support issue or a question
    • Support issues and questions are handled at /r/uMatrix
  • I tried to reproduce the issue when...
    • uMatrix is the only extension
    • uMatrix with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uMatrix
  • I checked the documentation to understand that the issue I report is not a normal behavior
  • I used the logger to rule out that the issue is caused by my ruleset

Description

Download of images found with Google-Search doesn't work.
Similiar to #92

A specific URL where the issue occurs

https://user-images.githubusercontent.com/1280209/72898709-e5199f00-3d24-11ea-986a-430859134f6b.png

Steps to Reproduce

Search for a image in Googel, no matter which one.
Klick on any image in the search results, that the image is shown on the right side.
Klick on that image on the right side with right mouse button and choose "Show image" (sorry if it's called different, I'm on german firefox).
Image is now displayed.
Klick on that image with right mouse button and chooce "Save image under..."
Download failed.

Download only works when one allows "others" in uMatrix (See screenshots below)

Ruleset

Download not working
Active rules - Download not working

Download works
Active rules - Download works

-->

Supporting evidence

Firefox download history

-->

Your environment

  • uMatrix version: 1.4.0
  • Browser Name and version: Firfox 73.0.1
  • Operating System and version: Windows 10 1909 Build 18363.657
@uBlock-user
Copy link
Contributor

uBlock-user commented Mar 7, 2020

Download only works when one allows "others" in uBlock

Blocking "other" column specifically for first-party is expected to cause download breakage because download requests type are "other" in nature. This is not the same as the bug you mentioned because that bug had downloading working at the second attempt. Here, you're willfully blocking the other column and expecting the download to work which it wont.

@uBlock-user
Copy link
Contributor

uBlock-user commented Mar 7, 2020

@Shudushi
Copy link
Author

Shudushi commented Mar 7, 2020

This is not the same as the bug you mentioned because that bug had downloading working at the second attempt.

When one klicks on "retry" in Firefox download history (with "other" blocked) it downloads succesfully.
I can reproduce my workaround also on that problem and it works there too.

@uBlock-user
Copy link
Contributor

uBlock-user commented Mar 7, 2020

Can you try to reproduce on the dev build ?

@Shudushi
Copy link
Author

Shudushi commented Mar 7, 2020

Yes, I will try.

@uBlock-user
Copy link
Contributor

uBlock-user commented Mar 7, 2020

When one klicks on "retry" in Firefox download history (with "other" blocked) it downloads succesfully.

Retry requests are not sent to uMatrix, hence they bypass the extension, that's why it will always work from the Firefox's UI. Any network requests made by Firefox's UI will never be sent to extensions to intercept.

@Shudushi
Copy link
Author

Shudushi commented Mar 7, 2020

Behavior is different, but doesn't work too.
Doesn't work
Doesn't work
Doesn't work
Doesn't work
Doesn't work
Doesn't work
This is working
Working
This is working
Working

@uBlock-user
Copy link
Contributor

uBlock-user commented Mar 7, 2020

@Shudushi should work, I can't reproduce this issue on Firefox Nightly, so seems something changed in Firefox with the v75. In uMatrix's logger the download request is of category image and seen as tabless according to uMatrix, not other. The last two images shows CNAMEs getting blocked, so ofcourse you will have to unblock them too.

@uBlock-user uBlock-user added the something to address something to address label Mar 7, 2020
@Shudushi
Copy link
Author

Shudushi commented Mar 7, 2020

My fault, sorry. Had to allow github. Yes, confirmed. Its working now under v1.4.1b6.
Thanks a lot for your support.
Working

@uBlock-user
Copy link
Contributor

No actually I can reproduce download getting blocked when blocking other column in Firefox 73, but not on Firefox 75, so Firefox has changed the behaviour in the upcoming version.

@Shudushi
Copy link
Author

Shudushi commented Mar 7, 2020

Developer's business as usual ;-)

@Shudushi
Copy link
Author

Shudushi commented Mar 7, 2020

Btw. "https://pastebin.com/raw/HjWANtHk" from issue https://github.com/uBlockOrigin/uMatrix-issues/issues/92 is working too on Firefox v73.0.1
Working

@uBlock-user uBlock-user added the external an external factor is involved label Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external an external factor is involved something to address something to address
Projects
None yet
Development

No branches or pull requests

2 participants