Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot type double quotes in My Filters editor using Option + F #3447

Open
9 tasks done
anohren opened this issue Nov 8, 2024 · 16 comments
Open
9 tasks done

Cannot type double quotes in My Filters editor using Option + F #3447

anohren opened this issue Nov 8, 2024 · 16 comments

Comments

@anohren
Copy link

anohren commented Nov 8, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Thank you for a fantastic project 👌 and saving my attention from unrelenting attack.

I cannot type double quotes in My Filters editor using my usual keyboard layout (Svorak A5) using Option + F. Cursor instead moves to next word. It's very difficult to use text editors that override typing.

A specific URL where the issue occurs.

moz-extension://44f09695-93ee-ad48-9694-d471cdae835c/dashboard.html#1p-filters.html

Steps to Reproduce

  1. Install Svorak A5 for macOS and switch to that layout
  2. Go to My Filters settings pane
  3. Try to type " using Option + F

Expected behavior

The character I type appears in the text editor

Actual behavior

Caret moves to next word ending

uBO version

1.60.0

Browser name and version

Firefox 115.16.1esr

Operating System and version

macOS 10.14.6 Mojave

@gwarser
Copy link

gwarser commented Nov 9, 2024

Does it work on this page: https://codemirror.net/5/ ?

@garry-ut99

This comment was marked as abuse.

@anohren
Copy link
Author

anohren commented Nov 9, 2024

@garry-ut99 Thanks for the reference.

I did visit the wiki page you link to, and I did visit the first link to https://codemirror.net/index.html. From there I couldn't find a user manual on their Documentation page, after which I did not follow any more links to CodeMirror's site.

I probably wouldn't have missed it if the first link to them wasn't there in the wiki 🙂

Edit: also, the second link just appears to link to contents that you have already published on the wiki page, hence the "no need to visit that link" reaction.

Anyway, it's still a problem, but what I can gather from the linked issue it can only be fixed by clients, by implementing e.g. a "disable keyboard shortcuts" button?

I'll leave it to you to decide whether it's worth it to support arbitrary (programming) keyboard layouts. I personally don't do a lot of typing in uBlock, but let's just say I avoid Google drive/docs 😅 They've built the office equivalent of a game without configurable controls.

@gorhill
Copy link
Member

gorhill commented Nov 9, 2024

I did visit the first link to https://codemirror.net/index.html. From there I couldn't find a user manual

You were asked whether you have the same issue with the embedded editor at https://codemirror.net/5/. If so, then it means CodeMirror 5 does not support custom keyboard layouts.

image

@anohren
Copy link
Author

anohren commented Nov 9, 2024

That will have to wait until I'm at my computer I'm afraid.

@garry-ut99

This comment was marked as off-topic.

@anohren

This comment was marked as off-topic.

@anohren
Copy link
Author

anohren commented Nov 9, 2024

Does it work on this page: https://codemirror.net/5/ ?

Typing double quotes seems to work fine there.

@gorhill
Copy link
Member

gorhill commented Nov 9, 2024

In that case, I will let whoever can reproduce to investigate and suggest a fix.

@garry-ut99

This comment was marked as off-topic.

@gwarser
Copy link

gwarser commented Nov 9, 2024

Layout can be installed on other systems https://svorak.ahall.se/download.php

Layout does not work for me on Manjaro, and on Windows 11 correctly inserts " with Alt - Alt+Y.

uBO 1.60.0, Firefox 132.0.1.

@anohren

This comment was marked as off-topic.

@gorhill
Copy link
Member

gorhill commented Nov 10, 2024

Layout does not work for me on Manjaro

Linux Mint in a virtual machine, I enabled "Swedish (Dvorak A5)", which causes my Y key to become F, with Right Alt-Y for ", and it worked correctly on my side, I could enter double quotes. This will have to be investigated by someone else who can reproduce with a Mac OS.

image

@garry-ut99

This comment was marked as off-topic.

@gorhill

This comment was marked as off-topic.

@garry-ut99

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants