Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generichide exception filter not preventing *##... cosmetic filters from being applied #254

Open
8 of 9 tasks
WesCooast opened this issue Dec 4, 2024 · 6 comments
Open
8 of 9 tasks

Comments

@WesCooast
Copy link

Prerequisites

  • This is NOT a YouTube, Facebook, Twitch or a shortener/hosting site report. These sites MUST be reported by clicking their respective links.
  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.)
  • I am not using uBO Lite along with other content blockers.
  • I have verified that the issue still exists after using the Optimal or Complete filtering mode.
  • I have verified that the web browser's built-in content blocker/tracking protection, network wide/DNS blocking, or my VPN is not causing the issue.
  • I have verified that other extensions are not causing the issue.
  • If this is about a breakage or detection, I have verified that it is caused by uBOL Lite and isn't a site issue.
  • I did not answer truthfully to ALL the above checkboxes.

URL address of the web page

https://vectr.com/editor/ee5a5a84-3c2a-4535-a8e3-ba7b58aea679

Category

[unknown]

Description

The website is showing a popup asking to remove the adblocker to have access

Other extensions used

Mailtracker
Scribbr
Dealabs
ColorZilla

Screenshot(s)

Screenshot(s)

Configuration

version: uBOL 2024.12.2.22
mode: optimal / optimal
rulesets:
 default
 block-lan
 dpollock-0
 adguard-spyware-url
 annoyances-cookies
 annoyances-overlays
 annoyances-social
 annoyances-widgets
 annoyances-others
 stevenblack-hosts
 fin-0
 fra-0
 est-0
@stephenhawk8054 stephenhawk8054 changed the title vectr.com: [unknown] vectr.com: detection Dec 4, 2024
@stephenhawk8054
Copy link
Member

Test again in a new browser profile with only uBOL and its default settings + Optimal mode.

@gorhill
Copy link
Member

gorhill commented Dec 5, 2024

I can reproduce with same lists as OP:

image

Investigating.

@gorhill
Copy link
Member

gorhill commented Dec 5, 2024

Caused by ~nettimokki.com##div[id*=AdContainer] in FIN list.

This is an open issue: #202 (comment)

For now, downgrading filtering mode to Basic for that site makes the detection go away. This will have to be the solution until the issue is fixed in uBOL.

@gorhill gorhill transferred this issue from uBlockOrigin/uAssets Dec 5, 2024
@gorhill gorhill changed the title vectr.com: detection generichide exception filter not preventing *##... cosmetic filters from being applied Dec 5, 2024
@stephenhawk8054
Copy link
Member

We can add

vectr.com##+js(trusted-replace-argument, document.querySelector, 0, json:"#root", condition, #AdContainer)

in uBOL list as a temp solution without users downgrading to Basic?

@gorhill
Copy link
Member

gorhill commented Dec 5, 2024

As you wish, but personally I think downgrading to Basic just for that site is a reasonable workaround and we won't have to keep track of the filters added as a temporary fixes until the root problem is fixed in the source code.

@stephenhawk8054
Copy link
Member

Yeah, I just think again, other filters benefited from optimal don't really affect this site so Basic is still good.

gorhill added a commit to gorhill/uBlock that referenced this issue Dec 8, 2024
Related issue:
uBlockOrigin/uBOL-home#254

Cosmetic filters with only negated hostnames would end up being
classified as specific, while in reality the filter is generic, with
specific exceptions.

This commit fixes the improper classification. Enforcing specific
exception filters in the generic realm is still an issue to
address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants