-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generichide
exception filter not preventing *##...
cosmetic filters from being applied
#254
Comments
Test again in a new browser profile with only uBOL and its default settings + Optimal mode. |
Caused by This is an open issue: #202 (comment) For now, downgrading filtering mode to Basic for that site makes the detection go away. This will have to be the solution until the issue is fixed in uBOL. |
generichide
exception filter not preventing *##...
cosmetic filters from being applied
We can add vectr.com##+js(trusted-replace-argument, document.querySelector, 0, json:"#root", condition, #AdContainer) in uBOL list as a temp solution without users downgrading to Basic? |
As you wish, but personally I think downgrading to Basic just for that site is a reasonable workaround and we won't have to keep track of the filters added as a temporary fixes until the root problem is fixed in the source code. |
Yeah, I just think again, other filters benefited from optimal don't really affect this site so Basic is still good. |
Related issue: uBlockOrigin/uBOL-home#254 Cosmetic filters with only negated hostnames would end up being classified as specific, while in reality the filter is generic, with specific exceptions. This commit fixes the improper classification. Enforcing specific exception filters in the generic realm is still an issue to address.
Prerequisites
Optimal
orComplete
filtering mode.URL address of the web page
https://vectr.com/editor/ee5a5a84-3c2a-4535-a8e3-ba7b58aea679
Category
[unknown]
Description
The website is showing a popup asking to remove the adblocker to have access
Other extensions used
Mailtracker
Scribbr
Dealabs
ColorZilla
Screenshot(s)
Screenshot(s)
Configuration
The text was updated successfully, but these errors were encountered: