Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppeteer launch headless new #21

Open
scottg369 opened this issue Jul 26, 2023 · 1 comment
Open

puppeteer launch headless new #21

scottg369 opened this issue Jul 26, 2023 · 1 comment

Comments

@scottg369
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/google-charts-node/lib/render.js b/node_modules/google-charts-node/lib/render.js
index 0551607..21f4989 100644
--- a/node_modules/google-charts-node/lib/render.js
+++ b/node_modules/google-charts-node/lib/render.js
@@ -20,7 +20,7 @@ async function renderGoogleChart(contentRaw, optsRaw) {
     optsRaw || {},
   );
 
-  const browser = await puppeteer.launch(opts.puppeteerOptions);
+  const browser = await puppeteer.launch({headless: 'new'});
 
   const page = await browser.newPage();
   page.setDefaultTimeout(RENDER_TIMEOUT_MS);

This issue body was partially generated by patch-package.

@typpo
Copy link
Owner

typpo commented Jul 26, 2023

Hi Scott,

This behavior is supported via puppeteerOptions. For example:

const image = await GoogleChartsNode.render(drawChart, {
  width: 400,
  height: 300,
  puppeteerOptions: {
    headless: 'new'
  }
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants