Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi search result doesn't give Code and Message if something goes wrong #147

Open
vamshiaruru opened this issue Sep 15, 2023 · 1 comment

Comments

@vamshiaruru
Copy link

Description

If you make multiple searches using multisearch query, and if one of the queries causes an error somehow (for example a field which isn't a facet index is given as facet_by input), the response corresponding to that query is just an empty object and is not pouplated with code and message. This is because the response object is just SearchResult which doesn't have Code & Message fields, so when you unmarshal the data is gone.
The way to fix this IMO would be to add a separate MultiSearchResultEle type which has everything in SearchResult but also has the Code and Error fields.

@vamshiaruru
Copy link
Author

I would like to raise a PR but I am unable to get the generator working. I made manual changes in this fork: master...vamshiaruru:typesense-go:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant