Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support backfill documents in subcollections #17

Open
eysenshi opened this issue Aug 27, 2021 · 5 comments · May be fixed by #52
Open

Support backfill documents in subcollections #17

eysenshi opened this issue Aug 27, 2021 · 5 comments · May be fixed by #52

Comments

@eysenshi
Copy link

Description

This is a request to support backfill all subcollections return from a collection group query. This could be helpful in use case like, backfill landmarks data from all cities under path: cities/{cityId}/landmarks.
@jasonbosco
Copy link
Member

Note to myself: docs for listening on dynamic paths: https://firebase.google.com/docs/functions/firestore-events#wildcards-parameters

@elhe26
Copy link

elhe26 commented Dec 13, 2021 •
edited

@jasonbosco, this extension supports subcollection paths? (ie. cities/{cityId}/landmarks)

@ChauCM
Copy link

ChauCM commented Dec 14, 2021

Subcollection like "cities/{cityId}/landmarks" worked for me on indexToTypesenseOnFirestoreWrite but not on backfill: backfillToTypesenseFromFirestore. Basically the backfill function runs without error but no record is imported.

@guenth39
Copy link

guenth39 commented Apr 20, 2023 •
edited

@jasonbosco Any plans to implement this? I would really need this feature!

@guenth39
Copy link

The issue should be fixed by changing this line in the backfill cloud function

firestore-typesense-search/functions/src/backfillToTypesenseFromFirestore.js

Lines 43 to 44 in 44e01a7

const querySnapshot =
await admin.firestore().collection(config.firestoreCollectionPath).get();

In the case of a subcollection, we have to use collectionGroup instead of collection.

This was referenced Apr 20, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@jasonbosco @elhe26 @guenth39 @eysenshi @ChauCM