-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Quickstart guide should be clear on type: module not being a requirement #9094
Comments
The reason we didn't specify this is because we treated it as assumed knowledge for using NodeJS. My question here would be - do we need to tell people the constraints of NodeJS? Or are we okay to assume that people know "if you don't use ESM then you must translate this to CJS". cc @typescript-eslint/triage-team thoughts? With the release of eslint 8.57.0 we could update this guide to use |
Personally I'm +1 on recommending using Also see the related conversation on Discord: https://discord.com/channels/1026804805894672454/1207049165079846962/1213212499713728553 |
+1 on calling out explicitly, and mentioning .mjs option. |
I think it's important to mention +add external references. A lot of people are just setting up the dev environment and may not be familiar with intricacies of the various stack options. Most how-to's start with do yarn add my-package so it's fair to point out anything that a noob will need. Aim for bullet proof instructions for idiot users like me! 🙂 |
Yeah, we need to be very careful to note that it's not a requirement to use a module type. |
@bradzacher this is not true:
I understand that you mention the A lot (and I mean a looooot) of people are convinced that the |
Before You File a Documentation Request Please Confirm You Have Done The Following...
Suggested Changes
Improve the getting-started/Quickstart guide to mention that package.json must have "type":"module" otherwise the example will fail with import statement not being supported
Affected URL(s)
https://typescript-eslint.io/getting-started/
The text was updated successfully, but these errors were encountered: