Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo: Raise TSConfig lib/target support range to match ESLint's #9028

Open
JoshuaKGoldberg opened this issue Apr 29, 2024 · 0 comments
Open
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Milestone

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Apr 29, 2024

Suggestion

ESLint uses Object.hasOwn() (e.g. in lib/rules/prefer-object-has-own). That's a good sign that we should be able to use it too!

But, our TSConfig lib range is only up to "ES2021" right now. That doesn't allow Object.hasOwn. Which makes me think that we should upgrade our lib and/or target in our TSConfigs to match ESLint's to at least... "ES2022"? Investigation required.

Note: please target this against the v8 branch. Just to be safe, let's treat it as a followup to #8929 -> #8973.

💖

@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Apr 29, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

No branches or pull requests

1 participant