feat: first approach to find existing eslint config #724
Conversation
| globAsync: GlobAsync; | ||
| }; | ||
|
|
||
| export const findExistingESLintConfiguration = async ( |
There was a problem hiding this comment.
Heh, yeah, the return type of this is what I was curious about... At first, I was thinking thinking the calling code will want to know whether this is an npm package style file or an ESLint one. For example, what happens if someone does something like --config ./packages/somewhere/package.json, and wants this to work on the eslintConfig in that nested file?
But, it's really only package.json files that have the odd eslintConfig member... Maybe the writing code would always want to override an existing eslintConfig in the output file if that output file's name ends with "package.json"? What do you think
| status: ResultStatus.Failed, | ||
| }; | ||
| } | ||
| if (globResult instanceof Error && typeof packageContent === "string") { |
There was a problem hiding this comment.
Nit, just marking this down because it confused me at first 😛
| if (globResult instanceof Error && typeof packageContent === "string") { | |
| if (typeof packageContent === "string") { |
|
Closing to keep the PR queue small. fyi @KingDarBoja 👍 thanks for the work on mapping out a first approach! |
PR Checklist
status: accepting prsOverview