Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import/no-internal-modules is not a great substitution for TSLint's no-submodule-imports #1111

Open
ProdigyChrisLight opened this issue Jun 2, 2021 · 2 comments
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨

Comments

@ProdigyChrisLight
Copy link

ProdigyChrisLight commented Jun 2, 2021

🐛 Bug Report

  • tslint-to-eslint-config version: 2.6.0
  • ESLint version: 7.26.0
  • Node version: 10.16.1

Actual Behavior

Relates to: #175

import/no-internal-modules is not a great substitution for TSLint's no-submodule-imports. no-submodule-imports prevents submodules from other node packages from being imported, where import/no-internal-modules will reject submodule imports from the same package. The latter is configurable, but not in a way that provides parity with the former.

Expected Behavior

A rule should be substituted that provides the same behavior as no-submodule-imports. This issue is being discussed here: import-js/eslint-plugin-import#1430

Reproduction

Examples can be found at import-js/eslint-plugin-import#1430

@KingDarBoja KingDarBoja added the good first issue Good for newcomers; welcome aboard! label Jun 2, 2021
@JoshuaKGoldberg
Copy link
Member

👍 thanks for filing @ProdigyChrisLight!

Until some equivalent rule is provided per the linked issue, it sounds like we'll have to put a notices notice in the converter for no-submodule-imports that explains the difference.

@JoshuaKGoldberg JoshuaKGoldberg added area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments status: accepting prs Please, send in a PR to resolve this! ✨ labels Jun 2, 2021
@ghost
Copy link

ghost commented Jul 26, 2021

👍 thanks for filing @ProdigyChrisLight!

Until some equivalent rule is provided per the linked issue, it sounds like we'll have to put a notices notice in the converter for no-submodule-imports that explains the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨
Projects
None yet
Development

No branches or pull requests

3 participants