Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Merger: no-unnecessary-type-assertion is not needed #1061

Open
KingDarBoja opened this issue May 16, 2021 · 1 comment
Open

Rule Merger: no-unnecessary-type-assertion is not needed #1061

KingDarBoja opened this issue May 16, 2021 · 1 comment
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans

Comments

@KingDarBoja
Copy link
Collaborator

🚀 Feature Request

Existing Behavior

We do have declared a merger for the @typescript-eslint/no-unnecessary-type-assertion rule but this doesn't seems to require it as it is pretty much a 1:1 converter with the whitelist of types to ignore being mapped into typesToIgnore as stated in the ESLint docs.

Change Proposal

Cleanup the rule by removing the merger and adding the logic into the converter.

@JoshuaKGoldberg
Copy link
Member

...huh! I wonder if it used to be necessary, but isn't anymore?

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans labels May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans
Projects
None yet
Development

No branches or pull requests

2 participants