Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request #14

Open
gasmonso opened this issue Oct 25, 2023 · 7 comments
Open

Feature Request #14

gasmonso opened this issue Oct 25, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@gasmonso
Copy link

It would be great if the following two additions could be made:

  1. Stack the styles. It would be great to offer the ability to select up to three styles instead of having to chain them together.
  2. Output text of selected style as a String. In addition to the positive and negative prompts, it would be great to output the name of the selected style. This could be used to name files/directories when saving images.

Thanks for the custom node as I use it all the time!!!

@twri
Copy link
Owner

twri commented Oct 25, 2023

The stacking is possible with built in Comfy-logic see #13.
The output text is not a bad idea but not a feature many have requested or uses. I'll have to think about that.

@twri twri closed this as completed Oct 25, 2023
@twri twri reopened this Oct 25, 2023
@gasmonso
Copy link
Author

I'm currently stacking the styles that way and I use up to three which takes up space, added noodles, etc. I was just suggesting a single node that would allow for up to three styles in a nice compact clean node. As I use comfy more and more, I'm getting pretty complicated workflows and any way to minimize nodes, noodles, etc is great :)

Thanks for your quick reply btw!

@evilalmus
Copy link

I just started using these nodes today, adding my "+1" to the request for an output with the name of the used style. I'd like to be able to use it in output file naming.

On the other suggestion to be able to "stack the styles" I would also use this. I suggest allowing multiple JSON files and having a selector in the node to choose which file to use.

@evilalmus
Copy link

It would also be useful to have the name as an output for building an X/Y grid.

@twri
Copy link
Owner

twri commented Nov 8, 2023

There's no built in method that enables multiselect unfortunately so you have to rename the JSONs to disable/enable them.

@evilalmus
Copy link

That's too bad. I'm not a developer so I probably don't understand how this works, I had just assumed that if you could load all .json files you could, after loading them, filter based on which file the JSON object was loaded from.

@twri
Copy link
Owner

twri commented Nov 8, 2023

ComfyUI is mainly a workflow with some UI elements, nothing happens unless you queue something. It needs a good front end to match but it's not here yet.

@twri twri added the enhancement New feature or request label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants