Merge pull request #735 from twmb/example-messup

twmb · web-flow · commit 2bc29e65e9e0 · 2024-05-22T23:53:27.000-06:00
eos example: avoid short-circuit logic
diff --git a/examples/transactions/eos/main.go b/examples/transactions/eos/main.go
@@ -75,7 +75,8 @@ func inputProducer() {
 		for i := 0; i < 10; i++ {
 			cl.Produce(ctx, kgo.StringRecord(msg+strconv.Itoa(i)), e.Promise())
 		}
-		commit := kgo.TransactionEndTry(doCommit && e.Err() == nil)
+		perr := e.Err() // always evaluate e.Err() to ensure we do not short circuit in the logic below (doCommit && ... would fail if doCommit is false!)
+		commit := kgo.TransactionEndTry(doCommit && perr == nil)
 
 		switch err := cl.EndTransaction(ctx, commit); err {
 		case nil:

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,8 @@ func inputProducer() {`
`75`	`75`	`for i := 0; i < 10; i++ {`
`76`	`76`	`cl.Produce(ctx, kgo.StringRecord(msg+strconv.Itoa(i)), e.Promise())`
`77`	`77`	`}`
`78`		`- commit := kgo.TransactionEndTry(doCommit && e.Err() == nil)`
	`78`	`+ perr := e.Err() // always evaluate e.Err() to ensure we do not short circuit in the logic below (doCommit && ... would fail if doCommit is false!)`
	`79`	`+ commit := kgo.TransactionEndTry(doCommit && perr == nil)`
`79`	`80`
`80`	`81`	`switch err := cl.EndTransaction(ctx, commit); err {`
`81`	`82`	`case nil:`