Skip to content

Ja localize to short on 4-digit-number return wrong result #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zszwrsjf opened this issue Aug 5, 2024 · 1 comment
Open

Ja localize to short on 4-digit-number return wrong result #275

zszwrsjf opened this issue Aug 5, 2024 · 1 comment

Comments

@zszwrsjf
Copy link

zszwrsjf commented Aug 5, 2024

Describe the bug
1111.localize(:ja, format: :short).to_s Return 1, but not 1Kor 1千

To Reproduce
Do 1111.localize(:ja, format: :short).to_s in version 6.12.1

Expected behavior
A clear and concise description of what you expected to happen.
It can return 1000,
https://github.com/twitter/twitter-cldr-npm/blob/master/full/ja.js#L4326
Or 1千 to get more shorter.

I think 1千 is better.

@camertron
Copy link
Collaborator

Hmm, thanks for bringing this to my attention @zszwrsjf. Off the top of my head, I'm not sure what the problem is. In cases like this, the CLDR data is sometimes missing a value, TwitterCLDR isn't falling back to an ancestor locale, etc. I'm not sure when I'll be able to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants