Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finagle-http: Http methodbuilder does not allow setting sendInterrupts flag to backup request filter #962

Open
DieBauer opened this issue Nov 8, 2023 · 0 comments

Comments

@DieBauer
Copy link
Contributor

DieBauer commented Nov 8, 2023

The http.Methodbuilder does not allow setting the flag sendInterrupts in the BackupRequestFilter. This means that a backup request that has won, can still have a 'loser' request being requeued/retried, because the loser is not aware of an already won backup.

Describe the solution you'd like
I want to be able to pass the flag sendInterrupt to the http.Methodbuilder.idempotent(..) method, which then configures the BackupRequestFilter on the underlying client.Methodbuilder. Currently it's hardcoded to false.

Describe alternatives you've considered
Disabling backup requests is an option to not have this issue, however backup requests do add value in my case.
Another workaround is to use Java (everything is Scala package private, and java doesn't know about that concept so it's public accessible) and reflection to create such a configured client.Methodbuilder.

@DieBauer DieBauer changed the title finagle-core: Http methodbuilder does not allow setting sendInterrupts flag to backup request filter finagle-http: Http methodbuilder does not allow setting sendInterrupts flag to backup request filter Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant