You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The http.Methodbuilder does not allow setting the flag sendInterrupts in the BackupRequestFilter. This means that a backup request that has won, can still have a 'loser' request being requeued/retried, because the loser is not aware of an already won backup.
Describe the solution you'd like
I want to be able to pass the flag sendInterrupt to the http.Methodbuilder.idempotent(..) method, which then configures the BackupRequestFilter on the underlying client.Methodbuilder. Currently it's hardcoded to false.
Describe alternatives you've considered
Disabling backup requests is an option to not have this issue, however backup requests do add value in my case.
Another workaround is to use Java (everything is Scala package private, and java doesn't know about that concept so it's public accessible) and reflection to create such a configured client.Methodbuilder.
The text was updated successfully, but these errors were encountered:
DieBauer
changed the title
finagle-core: Http methodbuilder does not allow setting sendInterrupts flag to backup request filter
finagle-http: Http methodbuilder does not allow setting sendInterrupts flag to backup request filter
Nov 8, 2023
The http.Methodbuilder does not allow setting the flag
sendInterrupts
in the BackupRequestFilter. This means that a backup request that has won, can still have a 'loser' request being requeued/retried, because the loser is not aware of an already won backup.Describe the solution you'd like
I want to be able to pass the flag sendInterrupt to the http.Methodbuilder.idempotent(..) method, which then configures the BackupRequestFilter on the underlying client.Methodbuilder. Currently it's hardcoded to false.
Describe alternatives you've considered
Disabling backup requests is an option to not have this issue, however backup requests do add value in my case.
Another workaround is to use Java (everything is Scala package private, and java doesn't know about that concept so it's public accessible) and reflection to create such a configured client.Methodbuilder.
The text was updated successfully, but these errors were encountered: