Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate t.w.h.HTTPClient #12158

Open
twm opened this issue May 3, 2024 · 4 comments · May be fixed by #12171
Open

Deprecate t.w.h.HTTPClient #12158

twm opened this issue May 3, 2024 · 4 comments · May be fixed by #12171
Assignees

Comments

@twm
Copy link
Contributor

twm commented May 3, 2024

Is your feature request related to a problem? Please describe.

I think this speaks for itself:

class HTTPClient(basic.LineReceiver):
"""
A client for HTTP 1.0.

It looks like we forgot to deprecate and remove this along with getPage and friends (in #10295).

Describe the solution you'd like

Deprecate it, and file a ticket to remove it per policy.

Describe alternatives you've considered

Leave it sitting there like a footgun. 🤷‍♂️

Additional context

See #735 (comment) and note #12159.

@adiroiban
Copy link
Member

+1 deprecate it... and I think that we should just skip trying to fix the existing bugs

@glyph
Copy link
Member

glyph commented May 3, 2024

👍

@glyph
Copy link
Member

glyph commented May 3, 2024

FWIW I think the reason it has lingered on so long is that it's the backing for getPage, which the docs use a bunch

@twm
Copy link
Contributor Author

twm commented May 4, 2024

getPage was removed in #10295 so I'll clean up any lingering references as part of this.

@twm twm self-assigned this May 4, 2024
@twm twm linked a pull request May 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants