#12146 Remove support for SOAP. #12148
Conversation
|
Mailing list announcement set , as requested by our compatiblity policy: https://mail.python.org/archives/list/[email protected]/thread/ZRJNWJY6XBMBICHF2TCEVECASWKWS6PT/ needs-review |
|
The current codecov.io reports are "optional" and they will not block a merge. When a log of code is removed, it is expected to see a drop in overal project coverage. the macOS tests are requried, and they will block the merge :( |
|
Let's see how macOS does with the fix on trunk :) |
|
Thanks for the review. I am waiting 1 week, as requested by the procees, and then will merge. The process requires the approval of 3 contributors ... but given that the Twisted project was not very actively lately, I guess that it's ok to merge with the aproval of a single contributor. I hope that I will not forget about it |
It does! External reviews are always appreciated; obviously you can't merge stuff, but we take it into account. |
|
Thanks for your reviews. I hope it will land soon. |
CodSpeed Performance ReportMerging #12148 will not alter performanceComparing Summary
|
Scope and purpose
Fixes #12146
Also all the existing SOAP tickets.
Fixes #3284
Fixes #3283
Fixes #4729
This removes the SOAP code.
It looks like the SOAP code was broken for many releases and nobody complained.
The automated tests were alwasy skipped... as SOAPPY was never installed as part of the CI process.
Also, we don't have a mantainer for the SOAP code.
I think that if anyone want to add support for SOAP in twisted, is best to create a separate independent twisted/txsoap repo