Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the soap code #12146

Closed
adiroiban opened this issue May 1, 2024 · 0 comments · Fixed by #12148
Closed

Remove the soap code #12146

adiroiban opened this issue May 1, 2024 · 0 comments · Fixed by #12148

Comments

@adiroiban
Copy link
Member

          Thanks for the feedback.

I think that is safe to just remove the SOAP code

It is already broken.

It looks like we still have code that was not ported to py3 ... or for which we don't execute the tests.

If anyone want to have SOAP support in Twisted, they can send a PR

$ pip install soappy
$ python
Python 3.12.2 (main, Feb 25 2024, 16:35:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from twisted.web.soap import SOAPPublisher
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/adi/chevah/twisted/src/twisted/web/soap.py", line 19, in <module>
    import SOAPpy
  File "/home/adi/chevah/twisted/venv-3.12/lib/python3.12/site-packages/SOAPpy/__init__.py", line 3, in <module>
    from version import __version__
ModuleNotFoundError: No module named 'version'
>>> 

Originally posted by @adiroiban in #12145 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant