fix: Create custom deserializer to optionally URL encode query parameters #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplied to any url field of your choosing.
| urlEncoded += "?" + splitEncodeAndReassembleQueryParams(queryParams); | ||
| } | ||
| encodedUrl = | ||
| new URL(urlEncoded).toURI(); |
There was a problem hiding this comment.
I see some overlap between this and this. Recommend analyzing to determine what common logic can be extracted out.
| import java.net.URI; | ||
| import java.net.URISyntaxException; | ||
| import java.net.URLEncoder; | ||
| import java.nio.charset.StandardCharsets; |
There was a problem hiding this comment.
Don't think all these new imports are needed.
| @@ -379,6 +388,7 @@ private IncomingPhoneNumber(@JsonProperty("account_sid") | |||
| @JsonProperty("voice_method") | |||
| final HttpMethod voiceMethod, | |||
| @JsonProperty("voice_url") | |||
| @JsonDeserialize(using = com.twilio.converter.UriEncodingDeserializer.class) | |||
There was a problem hiding this comment.
This file (and the test file) are generated files (see header at top of files). If we're to make this change in the generator, it would affect all URI param types. I think this is fine, but just calling it out here,
|
Closing until PR feedback is addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #577
This PR adds a custom deserializer to allow the sdk to properly deserialize urls of the form "http://test.test.com?param=this is a param" into a properly url-encoded URI object. this is currently only applied to the 'voice_url' field returned in the IncomingPhoneNumber, but can easily be added to other fields as needed. Maintains backwards and future compatibility with all response types, no breaking changes.
Checklist