fix: Added missing model definitions for statistics #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jassent
changed the title
jassent
changed the title
jassent
changed the title
|
The changes are to generated code so we'll have to make changes in the generator. We have this on our internal backlog (DI-2274) |
Understood. Thank you for reviewing and the explanation. Up to you whether or not to close. |
childish-sambino
added
the
status: waiting for feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Resolves: #624
Fixes these statistics models:
Twilio.Rest.Taskrouter.V1.Workspace.Worker.WorkerStatisticsResource
Twilio.Rest.Taskrouter.V1.Workspace.Worker.WorkersCumulativeStatisticsResource
Twilio.Rest.Taskrouter.V1.Workspace.Worker.WorkersRealTimeStatisticsResource
The prior models are missing definitions for statistical subresources that cause deserialization to return empty/null. Other statistics models are impacted by this same issue. Suggest that developers check for other statistics definitions using object instead of a strongly typed object.
Checklist
addedran tests that prove my fix is effective or that my feature works