[Side Modal]!: Align Side Modal footer actions to left #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: b2f65ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b2f65ef. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: -1 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
dosubot
bot
added
the
size:S
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b2f65ef:
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
breaking-change-side-modal
|
| Run status |
|
| Run duration | 02m 06s |
| Commit |
|
| Committer | Shoaib Ahmed |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
krisantrobus
reviewed
Nov 5, 2024
.changeset/smooth-ads-admire.md
Outdated
Comment on lines
2
to
3
| "@twilio-paste/side-modal": major | ||
| "@twilio-paste/core": major |
There was a problem hiding this comment.
Check with @nkrantz but if it's not a code breaking change and style should this just be a minor?
Suggested change
| "@twilio-paste/side-modal": major | |
| "@twilio-paste/core": major | |
| "@twilio-paste/side-modal": minor | |
| "@twilio-paste/core": minor |
There was a problem hiding this comment.
also might be nice to have a bit more context in the changeset as to why we're making this change and what design action is needed
There was a problem hiding this comment.
this is a nitpick but can you also add what design action is needed? so that someone looking at this change knows what they can/should do about it
There was a problem hiding this comment.
@nkrantz changeset updated
krisantrobus
previously approved these changes
Nov 5, 2024
PixeledCode
force-pushed
the
breaking-change-side-modal
branch
from
ab0aca4 to
b40268e
Compare
serifluous
approved these changes
Nov 6, 2024
PixeledCode
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
breaking-change-side-modal
|
| Run status |
|
| Run duration | 06m 19s |
| Commit |
|
| Committer | Shoaib Ahmed |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
nkrantz
approved these changes
Nov 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SideModalFooterActions