Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: incorrect $font-size-base value #4117

Open
1 of 3 tasks
dimitri-kandassamy opened this issue Oct 22, 2024 · 1 comment
Open
1 of 3 tasks

docs: incorrect $font-size-base value #4117

dimitri-kandassamy opened this issue Oct 22, 2024 · 1 comment
Labels
Area: Tokens Comments and questions related to tokens External This Discussion was posted by a non-Twilio Paste consumer Fix/Change in Backlog DSYS has acknowledged this improvement and will update the thread with results when we prioritize it Type: Bug Something isn't working Type: Documentation Improvements or additions to documentation

Comments

@dimitri-kandassamy
Copy link

dimitri-kandassamy commented Oct 22, 2024

Description

When I looked up the documentation for$font-size-base design token I expected to find a value of 16px whereas I saw 100% and 1600px.

Link to Reproduction

https://paste.twilio.design/tokens/list#font-sizes

Steps to reproduce

  1. Go to https://paste.twilio.design/tokens/list#font-sizes
  2. Scroll down to $font-size-base
  3. Observations: value: 100%, altValue: 1600px
  4. Expected: value: 1rem, altValue: 16px
Screenshot 2024-10-22 at 18 09 56

token definition in the code

Paste Core Version

20.16.0

Browser

No response

Operating System

  • macOS
  • Windows
  • Linux

Additional Information

No response

@dosubot dosubot bot added Area: Tokens Comments and questions related to tokens Type: Documentation Improvements or additions to documentation labels Oct 22, 2024
@serifluous serifluous added External This Discussion was posted by a non-Twilio Paste consumer Type: Bug Something isn't working Fix/Change in Backlog DSYS has acknowledged this improvement and will update the thread with results when we prioritize it labels Oct 24, 2024
@serifluous
Copy link
Member

Thanks for catching this @dimitri-kandassamy ! We've added a ticket for this in our backlog to fix the calculation here:

const pxValue = Math.round(remValue * PX_PER_REM);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tokens Comments and questions related to tokens External This Discussion was posted by a non-Twilio Paste consumer Fix/Change in Backlog DSYS has acknowledged this improvement and will update the thread with results when we prioritize it Type: Bug Something isn't working Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants