-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark dropdowns/navbars don't get dark variables with dark theme #39984
Comments
I think this is still a bug, or at least the statement in the docs is misleading: "Instead of adding .dropdown-menu-dark, set data-bs-theme="dark" on the root element, a parent wrapper, or the component itself". That is not the case for either dropdowns or navbars (and possibly other "dark" variables). And in fact for To use one variable as an example: In _variables.scss there's Another example: _variables.scss I think this could have slipped by since some of the colors are so similar, but if you set all of the |
Hi there, I want to contribute to this project and take on this issue as my first task. Could you please assign it to me? I am excited to work towards resolving it and will keep the team updated on my progress. Thanks |
Prerequisites
Describe the issue
There are two separate but I think related issues:
.navbar-dark
is marked as deprecated in 5.3, and addingdata-bs-theme="dark"
to it enables dark color variables. However, setting it on a parent component does not enable those variables..dropdown-menu-dark
is marked as deprecated in 5.3 butdata-bs-theme="dark"
doesn't work at all.Dark navbar code:
Dark dropdown code:
I think I would expect both to work like this:
Reduced test cases
Use the dark mode toggle on the documentation site, when in dark mode the dropdowns/navbars do not have the configured dark styles that appear when specifically setting
navbar-dark
ordropdown-menu-dark
.What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
v5.3.3
The text was updated successfully, but these errors were encountered: