Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to TypeScript #114

Open
slifty opened this issue May 31, 2021 · 1 comment
Open

Move to TypeScript #114

slifty opened this issue May 31, 2021 · 1 comment

Comments

@slifty
Copy link
Member

slifty commented May 31, 2021

Task

Description

TypeScript will do a lot for this project.

(1) We already have a forced concept of abstract classes, types, and interfaces in the ecosystem. This could be done more robustly (and with fewer lint rule overrides) with TypeScript.
(2) This will allow TypeScript projects to use TV Kitchen.
(3) We could remove runtime type checks in the countertop (speeding up the project).

Converting Base to TypeScript is the right first step.

It may turn out that some of the base packages become obsolete / certain things like interfaces should be moved to the countertop directly, but I'll leave that decision to the time of implementation

slifty added a commit that referenced this issue May 31, 2021
The build step would not remove old artefacts, which could result in
naming collisions in situations where a compiled object's case changed
on case-insensitive operating systems.

Issue #114
@slifty
Copy link
Member Author

slifty commented May 13, 2022

Instead of updating this repo directly I'd actually like to deprecate it and move the code over to countertop. See tvkitchen/countertop#154)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant