Linkify plain text emails #8585
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrb-hub
force-pushed
the
8568-linkify-plain-text
branch
from
7a8b118 to
589010c
Compare
hrb-hub
force-pushed
the
8568-linkify-plain-text
branch
from
589010c to
d2d4d3e
Compare
charlag
reviewed
Feb 21, 2025
| let bodyToSanitize: string = rawBody | ||
|
|
||
| const headers = await this.getHeaders() | ||
| if (headers?.includes("Content-Type: text/plain")) { |
There was a problem hiding this comment.
I'm a bit reluctant to rely on the headers. If you send an internal email while using "plain-text mode" it won't work. It might also be surprising why it works but only sometimes. I can also see why it might be worth it though.
There was a problem hiding this comment.
You're right, maybe it's not worth the confusion. I also found it weird that the example broken mail from the original issue now renders fine, it could be worth investigating. Maybe we can re-enable linkify for all mails.
Moving this to blocked for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.